Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix macOS and Windows builds in Github Actions #6649

Merged
merged 12 commits into from
Jan 20, 2020
Merged

Fix macOS and Windows builds in Github Actions #6649

merged 12 commits into from
Jan 20, 2020

Conversation

da1nerd
Copy link
Contributor

@da1nerd da1nerd commented Jan 16, 2020 •
edited
Loading

Describe what your pull request addresses (Please include relevant issue numbers):

Please include detailed Test instructions for your pull request:

Standard Test Instructions for PR Review Process:

  • Double check unit tests that have been written
  • Check for documentation for code changes
  • Check that there are not inadvertent commits to tC Apps when reviewing a tC Core PR
  • Checkout the branch locally and ensure that app runs as expected
    • Ensure tests pass
    • Open and watch the console for errors
    • Make sure all actions perform as expected
    • Import and Load a new Project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Switch project to an existing project
    • Load a tool and perform basic actions
    • Switch tools and perform basic actions
    • Next time reverse the order of importing after loading an existing project
  • Reviewer should double check the DoD in the ISSUE, including the “spirit” of the story
  • Ask Ben or Koz if you have any concerns about implementation (especially UI related)

This change is Reviewable

@da1nerd da1nerd self-assigned this Jan 16, 2020
@codecov
Copy link

codecov bot commented Jan 16, 2020 •
edited
Loading

Codecov Report

Merging #6649 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #6649   +/-   ##
========================================
  Coverage    60.46%   60.46%           
========================================
  Files          278      278           
  Lines        10485    10485           
  Branches      1715     1715           
========================================
  Hits          6340     6340           
  Misses        3690     3690           
  Partials       455      455

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0906494...8abf69c. Read the comment docs.

@dsm-git
Copy link

dsm-git commented Jan 16, 2020

Linux build 2.1.0 (b597e67) is ready for download.
macOS build 2.1.0 (b597e67) is ready for download.
Windows x64 build 2.1.0 (b597e67) is ready for download.
Windows x32 build 2.1.0 (b597e67) is ready for download.

@dsm-git
Copy link

dsm-git commented Jan 16, 2020

Linux build 2.1.0 (c551791) is ready for download.
macOS build 2.1.0 (c551791) is ready for download.
Windows x64 build 2.1.0 (c551791) is ready for download.
Windows x32 build 2.1.0 (c551791) is ready for download.

@da1nerd da1nerd changed the title Fix macOS builds in Github Actions Fix macOS and Windows builds in Github Actions Jan 16, 2020
@dsm-git
Copy link

dsm-git commented Jan 16, 2020

Linux build 2.1.0 (3e1f6bf) is ready for download.
macOS build 2.1.0 (3e1f6bf) is ready for download.
Windows x64 build 2.1.0 (3e1f6bf) is ready for download.
Windows x32 build 2.1.0 (3e1f6bf) is ready for download.

@dsm-git
Copy link

dsm-git commented Jan 16, 2020

Linux build 2.1.0 (aebb07e) is ready for download.
macOS build 2.1.0 (aebb07e) is ready for download.
Windows x64 build 2.1.0 (aebb07e) is ready for download.
Windows x32 build 2.1.0 (aebb07e) is ready for download.

@dsm-git
Copy link

dsm-git commented Jan 16, 2020

Linux build 2.1.0 (e0b3864) is ready for download.
macOS build 2.1.0 (e0b3864) is ready for download.
Windows x64 build 2.1.0 (e0b3864) is ready for download.
Windows x32 build 2.1.0 (e0b3864) is ready for download.

@dsm-git
Copy link

dsm-git commented Jan 16, 2020

Linux build 2.1.0 (62c8595) is ready for download.
Some builds failed

@dsm-git
Copy link

dsm-git commented Jan 16, 2020

Linux build 2.1.0 (56674be) is ready for download.
macOS build 2.1.0 (56674be) is ready for download.
Windows x64 build 2.1.0 (56674be) is ready for download.
Windows x32 build 2.1.0 (56674be) is ready for download.

@da1nerd da1nerd marked this pull request as ready for review January 16, 2020 10:49
@dsm-git
Copy link

dsm-git commented Jan 16, 2020

Some builds failed

@da1nerd
Copy link
Contributor Author

da1nerd commented Jan 16, 2020

@birchamp I'm not sure if you want to include this in the current sprint, but this fixes problems with github actions.

@dsm-git
Copy link

dsm-git commented Jan 16, 2020

Linux build 2.1.0 (75ae321) is ready for download.
macOS build 2.1.0 (75ae321) is ready for download.
Windows x64 build 2.1.0 (75ae321) is ready for download.
Windows x32 build 2.1.0 (75ae321) is ready for download.

PhotoNomad0
PhotoNomad0 reviewed Jan 20, 2020
View reviewed changes
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1, 1 of 1 files at r6.
Reviewable status: 2 of 3 files reviewed, all discussions resolved (waiting on @neutrinog)

@dsm-git
Copy link

dsm-git commented Jan 20, 2020

Linux build 2.1.0 (8abf69c) is ready for download.
macOS build 2.1.0 (8abf69c) is ready for download.
Windows x64 build 2.1.0 (8abf69c) is ready for download.
Windows x32 build 2.1.0 (8abf69c) is ready for download.

@PhotoNomad0
Copy link
Contributor

@neutrinog - well, it builds. Concerned about all the changes in package-lock just because dependency changes have caused us much grief in the past. Trying to think through how to verify the builds in the absence of integration testing. It looks like most are related to babel and http communication. So maybe just need to validate that tCore runs, and verify that Door43 uploads and downloads still work?

PhotoNomad0
PhotoNomad0 approved these changes Jan 20, 2020
View reviewed changes
Copy link
Contributor

@PhotoNomad0 PhotoNomad0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 2 files at r1.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @neutrinog)

@PhotoNomad0
Copy link
Contributor

LGTM - testing Windows and Mac builds

@PhotoNomad0 PhotoNomad0 merged commit 0460218 into develop Jan 20, 2020
@da1nerd da1nerd mentioned this pull request Jan 21, 2020
Closed
@mannycolon mannycolon deleted the bugfix-joel-github-actions branch February 3, 2020 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhotoNomad0 PhotoNomad0 PhotoNomad0 approved these changes

Assignees

@da1nerd da1nerd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@da1nerd @dsm-git @PhotoNomad0